President Donald Trump's decision to ban transgender service in the armed forces drove a wedge through military veterans in Congress.